Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize gmp8 part 1 #132

Merged
merged 20 commits into from
Jun 18, 2019
Merged

Finalize gmp8 part 1 #132

merged 20 commits into from
Jun 18, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Jun 18, 2019

  • Avoid duplicate code in tests
  • Add get_vulnerabilities, get_vulnerability
  • Add create_ticket, modify_ticket, delete_ticket, get_ticket, get_tickets and clone_ticket
  • Introduce a CredentialType enum for gmpv8
  • Expect CredentialType as argument for create_credential and modify_credential in gmpv8

Checklist:

The tests directory is moved to the beginning of the module search path.
Therefore "import xml.something" does fail in this case. Therefore avoid
using a xml module name for the tests.
Avoid including main heading and toc into the toc. Also use '-' for
unordered list in toc.
It seems the users are following the README very closely without knowing
pip semantics. Therefore mention only the best fitting installation
method.
Sphinx interprets the docstring as rst. Therefore using **kwargs expects
closing **.
Add GMP v8 to the docs
Update python-gvm to use GMPv8 as latest GMP protocol
Using base TestCase classes will allow to simplify the tests.
Implement API to receive vulnerability information.
@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #132 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   96.41%   96.56%   +0.15%     
==========================================
  Files          10       10              
  Lines        2480     2564      +84     
==========================================
+ Hits         2391     2476      +85     
+ Misses         89       88       -1
Impacted Files Coverage Δ
gvm/protocols/gmpv7.py 99.74% <ø> (ø) ⬆️
gvm/protocols/latest.py 100% <100%> (ø) ⬆️
gvm/protocols/gmpv8.py 100% <100%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b62e4...a683477. Read the comment docs.

@bjoernricks bjoernricks marked this pull request as ready for review June 18, 2019 07:37
@bjoernricks bjoernricks requested a review from a team June 18, 2019 07:37
gvm/protocols/gmpv8.py Outdated Show resolved Hide resolved
gvm/protocols/gmpv8.py Outdated Show resolved Hide resolved
gvm/protocols/gmpv8.py Show resolved Hide resolved
gvm/protocols/gmpv8.py Show resolved Hide resolved
gvm/protocols/gmpv8.py Outdated Show resolved Hide resolved
Allow to create, clone, delete, get and modify tickets.

Closes #95
We still need support for python 3.5 therefore don't add trailing commas
to method signatures.
Replace the CREDENTIAL_TYPES list with a CredentialType enum.
Expect a CredentialType instance for the credential_type arguments. It's
easier to use Enums for specific types for method arguments.
Document the correct id argument. Was a copy&paste mistake from the
protocol docs.
@bjoernricks bjoernricks merged commit 11d6abd into greenbone:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants